Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31357
to review the following change.
Change subject: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware ......................................................................
src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
G505S does not have any SAS or NVMe controllers and could not have a TPM, so it makes sense to disable the related SeaBIOS options for this laptop.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I5b2ee6403d7d2298725729d8d833e37627a4f202 --- M src/mainboard/lenovo/g505s/Kconfig A src/mainboard/lenovo/g505s/config_seabios 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/31357/1
diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index 883ef27..71ab909 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -55,4 +55,8 @@ string default "1002,990b"
+config PAYLOAD_CONFIGFILE + string + default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS + endif # BOARD_LENOVO_G505S diff --git a/src/mainboard/lenovo/g505s/config_seabios b/src/mainboard/lenovo/g505s/config_seabios new file mode 100644 index 0000000..8d3957b --- /dev/null +++ b/src/mainboard/lenovo/g505s/config_seabios @@ -0,0 +1,6 @@ +# +# SeaBIOS custom configuration for Lenovo G505S +# +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set +# CONFIG_TCGBIOS is not set