Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46038 )
Change subject: drivers/wifi/generic: Limit scope of ACPI-related functions to generic.c
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46038/1/src/drivers/wifi/generic/ch...
File src/drivers/wifi/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/46038/1/src/drivers/wifi/generic/ch...
PS1, Line 17: * @config: Generic wifi config required to fill ACPI SSDT table.
Should these comments be moved to generic.c?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46038
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cbb97f43d2d9f9ed6d3cf8f0a9b13a7f30e922e
Gerrit-Change-Number: 46038
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Oct 2020 15:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment