Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34929 )
Change subject: arch/x86: Fix spinlocks for cases of __PRE_RAM__ ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34929/4/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/c/coreboot/+/34929/4/src/console/printk.c@29 PS4, Line 29: if (ENV_STAGE_HAS_DATA_SECTION) : spin_lock(&console_lock); : else if (ENV_ROMSTAGE && CONFIG(HAVE_ROMSTAGE_CONSOLE_SPINLOCK)) : spin_lock(romstage_console_lock()); Just curious: You are not using a helper function here to get a pointer to the spinlock because the helper function could return NULL and spin_lock() might not necessarily be NOP depending upon which romstage spinlock configs have been selected.