Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36657 )
Change subject: lib/fmap: Add optional pre-RAM cache ......................................................................
Patch Set 8:
(7 comments)
https://review.coreboot.org/c/coreboot/+/36657/3/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/36657/3/src/arch/x86/car.ld@36 PS3, Line 36: FMAP_CACHE(., CONFIG_FMAP_CACHE_SIZE)
Decided to change this to just use FMAP_SIZE. […]
Ack
https://review.coreboot.org/c/coreboot/+/36657/3/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/c/coreboot/+/36657/3/src/include/memlayout.h@35 PS3, Line 35: #define STR(x) XSTR(x) : #define XSTR(x) #x
It makes it so the 'FMAP_SIZE' macro in the error message below will actually be expanded. […]
Ack
https://review.coreboot.org/c/coreboot/+/36657/3/src/include/memlayout.h@79 PS3, Line 79: FMAP_CACHE(addr, sz)
This is sort of a philosophical choice... […]
Ack
https://review.coreboot.org/c/coreboot/+/36657/1/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/36657/1/src/lib/cbfs.c@301 PS1, Line 301: /* Find location of header using signed 32-bit offset from
Does anyone know why we're still doing all this crap at all? Can I just take the offset and size fro […]
Done
https://review.coreboot.org/c/coreboot/+/36657/3/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/36657/3/src/lib/fmap.c@35 PS3, Line 35: print_once
Not sure I like this name... […]
Ack
https://review.coreboot.org/c/coreboot/+/36657/3/src/lib/fmap.c@64 PS3, Line 64: print_once(BIOS_WARNING, : "WARNING: Post-RAM FMAP access too early for cache!\n");
Yeah, that was what I was trying to express without making the message too long. […]
Done
https://review.coreboot.org/c/coreboot/+/36657/3/src/lib/fmap.c@305 PS3, Line 305: const ssize_t ret = rdev_readat(&fmrd, fmap, 0, s);
No, in the cached case fmrd is chained from fmap_cache here, which is the pre-RAM memory buffer. […]
Ack