Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35173 )
Change subject: soc/skylake: prevent null pointer dereferences
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip....
PS1, Line 156: (dev)
I personally prefer to leave the parentheses around the logical expression, as I find it easier to u […]
Just saw Patrick Georgi's comment on CB:35168 about the same thing, so I'll update these.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide10223e7fc37a6c4bfa408234ef3efe1846236a
Gerrit-Change-Number: 35173
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Name of user not set #1002476
Gerrit-Comment-Date: Mon, 02 Sep 2019 14:01:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1002476
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment