Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33565 )
Change subject: mb/asrock/h110m: rewrite gpio config using macros
......................................................................
Patch Set 23:
Patch Set 1:
Is the output of inteltool the same with/without this patch?
Now yes, except for some pads:
< old
new
128c140
< 0x0608: 0x0000002984000102 GPP_F4 GPIO
---
0x0608: 0x0000002984000100 GPP_F4 GPIO
159c171
< 0x06f8: 0x0000004784000102 GPP_G10 GPIO
---
0x06f8: 0x0000004784000100 GPP_G10 GPIO
But this does not affect the operation of the board
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01ad4bd29235fbe2b23abce5fbaaa7e63c87f529
Gerrit-Change-Number: 33565
Gerrit-PatchSet: 23
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-Comment-Date: Wed, 14 Aug 2019 17:21:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment