Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36415 )
Change subject: Documentation: Add amd_blobs license agreement text
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36415/2/Documentation/soc/amd/amdbl...
File Documentation/soc/amd/amdblobs_license.md:
https://review.coreboot.org/c/coreboot/+/36415/2/Documentation/soc/amd/amdbl...
PS2, Line 18: Copyright
Encapsulate whole license with block quote […]
Agh, I had all my comments still in draft! But thanks for marking it.
Oh, are those apostrophes? Looked like 2 sets of 3 periods to me; no wonder it didn't render properly. I'm fine with changing it if anyone believes it's hideous.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3dbc1a5259a2512281ea87b7e55fb3134b3b3c5
Gerrit-Change-Number: 36415
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment