Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32379 )
Change subject: src/mb: Use system_reset() ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
IMHO, I personally find the cf9 reset call names a bit hard to follow.
If I checked the proper files, there's at least one potential issue with this patch.
https://review.coreboot.org/#/c/32379/1/src/mainboard/asus/p5qpl-am/romstage... File src/mainboard/asus/p5qpl-am/romstage.c:
https://review.coreboot.org/#/c/32379/1/src/mainboard/asus/p5qpl-am/romstage... PS1, Line 195: system_reset Looks like it's not the same type of reset. If this does not power cycle the board, these straps will fail to be set.