Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37108 )
Change subject: cpu,soc/intel: Refactor em64t101 SMM relocate
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37108/8/src/cpu/intel/smm/gen1/smmr...
File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/37108/8/src/cpu/intel/smm/gen1/smmr...
PS8, Line 111: model_6fx, model_1067x and model_106cx
How about 6ex? 64t101 ?
Nope legacy, 32bit. This code works because the em64t100/em64t101 save state is larger than the legacy one but you might want to make that explicit with a MAX(sizeof(struct legacy...),sizeof(em64t100))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I177ca3b2966ccd985d72749ea2bd096ec4f233d6
Gerrit-Change-Number: 37108
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Nov 2019 12:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment