13 Oct
2020
13 Oct
'20
9:48 a.m.
Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46070 )
Change subject: src/drivers/ipmi: Add function to get BMC revision ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46070/2/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/46070/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 283: bmc_revision_major
How do you make sure bmc_revision_major contains valid data?
I've revised it in the last patch. It will check bmc_revision_major and bmc_revision_minor before parsing value.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46070
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaa4e8bf181a38452b53c83a762c7b648e95e643
Gerrit-Change-Number: 46070
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 06:48:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment