Attention is currently required from: Martin L Roth, Patrick Rudolph, Jakub Czapiga, Matt DeVillier, Angel Pons, Arthur Heymans, Martin Roth, Lean Sheng Tan.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: drivers/efi: Add EFI variable store option support
......................................................................
Patch Set 31:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52564/comment/2818b187_5635405a
PS13, Line 28: the test result
Not sure if the entire store can be cached in CAR stages, but it can certainly be cached in ramstage […]
Added to the list of possible performance improvements. If needed, it can be implemented later.
Commit Message:
https://review.coreboot.org/c/coreboot/+/52564/comment/8f9b053a_e3bfff42
PS29, Line 49: - Could enumerate all existing variables
: - Could read variables
: - Could write variables
Remove "Could": […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 31
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 02 Apr 2023 19:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment