Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47569 )
Change subject: nb/intel/sandybridge: Clean up `dram_mr2` function
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47569/2/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/47569/2/src/northbridge/intel/sandy...
PS2, Line 770: const u16 pasr = 0;
Is that variable needed at all? It only seems to be used once. (I have no idea what *pasr* is supposed to mean.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47569
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3829012ff7d41f4308ee84d6fbf3b1f2803431af
Gerrit-Change-Number: 47569
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Nov 2020 07:48:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment