[coreboot-gerrit] [M] Change in coreboot[main]: [RFC] region: Introduce region_create() functions

[Nico Huber (Code Review)]

Attention is currently required from: Andrey Petrov, Julius Werner, Jérémy Compostella, Martin L Roth, Maximilian Brune, Ronak Kanabar.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email )

Change subject: [RFC] region: Introduce region_create() functions
......................................................................

Patch Set 6:

(1 comment)

File src/commonlib/include/commonlib/region.h:

https://review.coreboot.org/c/coreboot/+/79905/comment/5fbf05c6_2ab8fbe8 :
PS1, Line 106: offset > SIZE_MAX || size > SIZE_MAX
> Hmmm... well, okay, if you feel strongly about it I guess it doesn't really hurt.
>
> However, don't you need to cast down to `size_t` for the overlap check?

Thanks! absolutely, yes, when the check is written like this.
> (Also, it would be a little more efficient to just create the region struct directly rather than calling `region_create()`, since you've already checked the overlap here, you don't need to go through that `assert()` again.)

Also true, good suggestion.