Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31123 )
Change subject: bootmem: add new memory type for BL31 ......................................................................
Patch Set 11: Code-Review+2
(3 comments)
https://review.coreboot.org/#/c/31123/11/src/arch/arm64/include/arch/memlayo... File src/arch/arm64/include/arch/memlayout.h:
https://review.coreboot.org/#/c/31123/11/src/arch/arm64/include/arch/memlayo... PS11, Line 41: 1K nit: Did you base this number on anything? The BL31 linker script aligns start and end of the ELF to PAGE_SIZE, so might as well make it 4K. (In practice, the required alignment depends on the secure address range protection granularity, which is usually higher but entirely platform-dependent.)
https://review.coreboot.org/#/c/31123/11/src/soc/nvidia/tegra210/soc.c File src/soc/nvidia/tegra210/soc.c:
https://review.coreboot.org/#/c/31123/11/src/soc/nvidia/tegra210/soc.c@41 PS11, Line 41: 0 nit: CARVEOUT_TZ
https://review.coreboot.org/#/c/31123/11/src/soc/nvidia/tegra210/soc.c@53 PS11, Line 53: for (i = 1; i < CARVEOUT_NUM; i++) { ...and here maybe (CARVEOUT_TZ + 1)?