Attention is currently required from: Martin Roth, Edward Dai, Frank Chu, Karthikeyan Ramasubramanian. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49923 )
Change subject: mb/google/dedede/var/Galith: Add Wifi SAR for Galith ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49923/comment/b7ce0ad7_9ae29a89 PS2, Line 7: G Galith->galith
https://review.coreboot.org/c/coreboot/+/49923/comment/c73b7a37_411f45e7 PS2, Line 7: for Galith for convertibles
https://review.coreboot.org/c/coreboot/+/49923/comment/12a91adf_546b5a44 PS2, Line 9: Add wifi sar for Galith: : Using tablet mode of fw config to decide to load custom wifi sar or not. Probe FW_CONFIG and load custom WiFi SAR for convertibles.
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/49923/comment/6c0a09bc_fe9c35b7 PS2, Line 1: Nit: Remove this extraneous line.
https://review.coreboot.org/c/coreboot/+/49923/comment/83e8119d_b19d20c8 PS2, Line 2: /* SPDX-License-Identifier: GPL-2.0-only */ Please add a blank line after the license header.
https://review.coreboot.org/c/coreboot/+/49923/comment/99c99ca3_adefaa59 PS2, Line 4: #include <sar.h> Please add a blank line after the include statements.
https://review.coreboot.org/c/coreboot/+/49923/comment/a0838433_f08f4b00 PS2, Line 7: const char *filename = NULL; Please add a blank like after the declaration block.