[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Use CPU common code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19566 )

Change subject: soc/intel/skylake: Use CPU common code
......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/#/c/19566/9/src/soc/intel/skylake/bootblock/cpu....
File src/soc/intel/skylake/bootblock/cpu.c:

PS9, Line 19: #include <intelblocks/cpu.h>
order

PS9, Line 22: set_strap_msg_dat
is this the function supposed to get called from common cpu code to soc, then name has to start with soc_

https://review.coreboot.org/#/c/19566/9/src/soc/intel/skylake/cpu.c
File src/soc/intel/skylake/cpu.c:

PS9, Line 30: #include <cpu/intel/microcode.h>
need this?