Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32608 )
Change subject: {gm45,pineview,sandybridge,x4x}: Use {full,system}_reset() function ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/gm45/early_res... File src/northbridge/intel/gm45/early_reset.c:
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/gm45/early_res... PS3, Line 67: /* Perform system reset through CF9 interface. */ not sure, if the comment is still useful
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/pineview/ramin... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/pineview/ramin... PS3, Line 1749: printk(BIOS_DEBUG, "Power cycle reset...\n"); I assume full_reset() already prints something like that.
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/sandybridge/ro... File src/northbridge/intel/sandybridge/romstage.c:
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/sandybridge/ro... PS3, Line 53: } Braces are not needed anymore.
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/x4x/raminit.c File src/northbridge/intel/x4x/raminit.c:
https://review.coreboot.org/#/c/32608/3/src/northbridge/intel/x4x/raminit.c@... PS3, Line 626: printk(BIOS_DEBUG, "Reset...\n"); full_reset() already prints something.