25 Mar
2020
25 Mar
'20
5:01 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39769 )
Change subject: nb/intel/haswell: Implement proper backlight PWM config ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39769/4/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/39769/4/src/northbridge/intel/haswe... PS4, Line 359: refclock / 128 / 100
With the exception of assignments, all binary operators in C are left-associative, […]
I tend to prefer "refclock / (128 * 100)", but I'm more used to writing math on treeware:
refclock ------------- 128 * 100
In any case, not a big deal.
--
To view, visit https://review.coreboot.org/c/coreboot/+/39769
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17dfe1a3610d5e2918c617cf5d10896692fdccb3
Gerrit-Change-Number: 39769
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Mar 2020 20:01:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment