Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/block: Add Intel common reset code
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG@7
PS5, Line 7: soc/intel/common/block
yes, i had thought on this as well but due to below reason I have decided to kept inside common bloc […]
Ack
https://review.coreboot.org/c/coreboot/+/45336/1/src/soc/intel/common/pch/re...
File src/soc/intel/common/pch/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/1/src/soc/intel/common/pch/re...
PS1, Line 14: cse_request_global_reset
initiate the test on SKL and KBL platform, will get back on result
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafe931ba9920501cf5448290ddd9f897760bb75
Gerrit-Change-Number: 45336
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Thu, 17 Sep 2020 10:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment