[coreboot-gerrit] Change in ...coreboot[master]: cpu/x86/mtrr: Fix shift into sign-bit in C

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31319 )

Change subject: cpu/x86/mtrr: Fix shift into sign-bit in C
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31319/1/src/include/cpu/x86/mtrr.h 
File src/include/cpu/x86/mtrr.h:

https://review.coreboot.org/#/c/31319/1/src/include/cpu/x86/mtrr.h@196 
PS1, Line 196: #define CACHE_ROM_BASE_C	_FROM_4G_TOP(1u, CACHE_ROM_SIZE)
> Can you use #if defined(__ASSEMBLER__) here to get different define for same name CACHE_ROM_BASE ?

Yeah, should have done. I was a little absent-minded it seems...