Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier.
Felix Held has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/77682?usp=email )
Change subject: soc/amd/cezanne: Add ACPI opregion to root complex ......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/cezanne/root_complex.c:
https://review.coreboot.org/c/coreboot/+/77682/comment/73224e35_50d711a1?usp... : PS6, Line 63: Add ACPI device, opregion to host bridge needed for Windows ACP driver. : * : * This provides a mailbox interface for the ACP drivers to notify the PSP : * that the DSP firmware has been loaded, so that the PSP can validate : * the firmware and set the qualifier bit to enable running it.
is this comment still valid? or should we make it more generic?
that should probably be reworked a bit. also i'll have to see if CB:86652 should be squashed into it, but still waiting on some test results on that one. i'll try to do the development in upstream, but the testing is done on some out of tree mainboard and right now i need to move there fast, so haven't gotten around to improve the comments and possibly commit messages