build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 )
Change subject: drivers/intel/fsp1_1/raminit.c: Make check FSP HOBs independent of CONFIG_DISPLAY_HOBS
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/29371/5/src/drivers/intel/fsp1_1/raminit.c
File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/#/c/29371/5/src/drivers/intel/fsp1_1/raminit.c@2...
PS5, Line 210: printk(BIOS_DEBUG,
code indent should use tabs where possible
https://review.coreboot.org/#/c/29371/5/src/drivers/intel/fsp1_1/raminit.c@2...
PS5, Line 210: printk(BIOS_DEBUG,
please, no space before tabs
https://review.coreboot.org/#/c/29371/5/src/drivers/intel/fsp1_1/raminit.c@2...
PS5, Line 210: printk(BIOS_DEBUG,
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29371
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d
Gerrit-Change-Number: 29371
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: York Yang
yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Apr 2019 08:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment