Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32284 )
Change subject: mediatek/mt8183: fix mode register setting fail issue
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32284/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32284/1//COMMIT_MSG@9
PS1, Line 9: the mode register setting of DRAM maybe failed without delay operate,
: need add delay after each MR write.
please refer to the source code of DramcModeRegWrite() from MT8183 preloader, not current coreboot s […]
How can I access the code, you released to Google?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51785e90b2014994be5018bfe543245d44626242
Gerrit-Change-Number: 32284
Gerrit-PatchSet: 2
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Comment-Date: Wed, 17 Apr 2019 13:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: huayang duan
huayangduan@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment