Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75078?usp=email )
Change subject: mb/siemens: Move selects from Kconfig.name to Kconfig ......................................................................
mb/siemens: Move selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files.
Change-Id: Ic199a60013ceedfd15b191a5fe707be6654ad3a2 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/75078 Reviewed-by: Werner Zeh werner.zeh@siemens.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/fa_ehl/Kconfig M src/mainboard/siemens/fa_ehl/Kconfig.name M src/mainboard/siemens/mc_apl1/Kconfig M src/mainboard/siemens/mc_apl1/Kconfig.name M src/mainboard/siemens/mc_ehl/Kconfig M src/mainboard/siemens/mc_ehl/Kconfig.name 6 files changed, 39 insertions(+), 13 deletions(-)
Approvals: Werner Zeh: Looks good to me, approved Mario Scheithauer: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/siemens/fa_ehl/Kconfig b/src/mainboard/siemens/fa_ehl/Kconfig index c673f9b..a2f8c89 100644 --- a/src/mainboard/siemens/fa_ehl/Kconfig +++ b/src/mainboard/siemens/fa_ehl/Kconfig @@ -7,6 +7,9 @@ select USE_SIEMENS_HWILIB select SOC_INTEL_DISABLE_POWER_LIMITS
+config BOARD_SIEMENS_FA_EHL + select BOARD_SIEMENS_BASEBOARD_FA_EHL + source "src/mainboard/siemens/fa_ehl/variants/*/Kconfig"
if BOARD_SIEMENS_BASEBOARD_FA_EHL diff --git a/src/mainboard/siemens/fa_ehl/Kconfig.name b/src/mainboard/siemens/fa_ehl/Kconfig.name index 0f9d062..b3bbe8a 100644 --- a/src/mainboard/siemens/fa_ehl/Kconfig.name +++ b/src/mainboard/siemens/fa_ehl/Kconfig.name @@ -2,4 +2,3 @@
config BOARD_SIEMENS_FA_EHL bool "-> FA EHL" - select BOARD_SIEMENS_BASEBOARD_FA_EHL diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig index 4701739..73efead 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/Kconfig @@ -7,6 +7,27 @@ select USE_SIEMENS_HWILIB select INTEL_LPSS_UART_FOR_CONSOLE
+config BOARD_SIEMENS_MC_APL1 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL2 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL3 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL4 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL5 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL6 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL7 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + source "src/mainboard/siemens/mc_apl1/variants/*/Kconfig"
if BOARD_SIEMENS_BASEBOARD_MC_APL1 diff --git a/src/mainboard/siemens/mc_apl1/Kconfig.name b/src/mainboard/siemens/mc_apl1/Kconfig.name index 9c9ff27..4fd32e50 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig.name +++ b/src/mainboard/siemens/mc_apl1/Kconfig.name @@ -2,28 +2,21 @@
config BOARD_SIEMENS_MC_APL1 bool "-> MC APL1" - select BOARD_SIEMENS_BASEBOARD_MC_APL1
config BOARD_SIEMENS_MC_APL2 bool "-> MC APL2" - select BOARD_SIEMENS_BASEBOARD_MC_APL1
config BOARD_SIEMENS_MC_APL3 bool "-> MC APL3" - select BOARD_SIEMENS_BASEBOARD_MC_APL1
config BOARD_SIEMENS_MC_APL4 bool "-> MC APL4" - select BOARD_SIEMENS_BASEBOARD_MC_APL1
config BOARD_SIEMENS_MC_APL5 bool "-> MC APL5" - select BOARD_SIEMENS_BASEBOARD_MC_APL1
config BOARD_SIEMENS_MC_APL6 bool "-> MC APL6" - select BOARD_SIEMENS_BASEBOARD_MC_APL1
config BOARD_SIEMENS_MC_APL7 bool "-> MC APL7" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 diff --git a/src/mainboard/siemens/mc_ehl/Kconfig b/src/mainboard/siemens/mc_ehl/Kconfig index 89d53c7..93b084d 100644 --- a/src/mainboard/siemens/mc_ehl/Kconfig +++ b/src/mainboard/siemens/mc_ehl/Kconfig @@ -9,6 +9,21 @@ select USE_SIEMENS_HWILIB select SOC_INTEL_DISABLE_POWER_LIMITS
+config BOARD_SIEMENS_MC_EHL1 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL2 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL3 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL4 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL5 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + source "src/mainboard/siemens/mc_ehl/variants/*/Kconfig"
if BOARD_SIEMENS_BASEBOARD_MC_EHL diff --git a/src/mainboard/siemens/mc_ehl/Kconfig.name b/src/mainboard/siemens/mc_ehl/Kconfig.name index 8ad4744..7f22703 100644 --- a/src/mainboard/siemens/mc_ehl/Kconfig.name +++ b/src/mainboard/siemens/mc_ehl/Kconfig.name @@ -2,20 +2,15 @@
config BOARD_SIEMENS_MC_EHL1 bool "-> MC EHL1" - select BOARD_SIEMENS_BASEBOARD_MC_EHL
config BOARD_SIEMENS_MC_EHL2 bool "-> MC EHL2" - select BOARD_SIEMENS_BASEBOARD_MC_EHL
config BOARD_SIEMENS_MC_EHL3 bool "-> MC EHL3" - select BOARD_SIEMENS_BASEBOARD_MC_EHL
config BOARD_SIEMENS_MC_EHL4 bool "-> MC EHL4" - select BOARD_SIEMENS_BASEBOARD_MC_EHL
config BOARD_SIEMENS_MC_EHL5 bool "-> MC EHL5" - select BOARD_SIEMENS_BASEBOARD_MC_EHL