Attention is currently required from: Arthur Heymans, Haribalaraman Ramasubramanian, Kapil Porwal, Nick Vaccaro, Shelley Chen, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80504?usp=email )
Change subject: soc/intel/alderlake: Remove CNVi assertions ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80504/comment/8f75b158_e9e4e216 : PS4, Line 12: This seems to make sense and allows us : to enable CNVi bluetooth when necessary.
Do you want to have some mechanism at runtime to change them?
Yes. Currently in Brox some SKUs within a same design use discrete WiFi/BT module and some use CNVi/BT as indicated in the TEST message. This is decided by probing the FW_CONFIG mask at run-time.
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/80504/comment/19b2c9ee_c8593712 : PS4, Line 836: if (!s_cfg->CnviMode && s_cfg->CnviWifiCore) { : printk(BIOS_ERR, "CNVi WiFi is enabled without CNVi being enabled\n"); : s_cfg->CnviWifiCore = 0; : } This check is not required since in alderlake they both are true when the CNVi PCH device is enabled - line 830 and 832. The situation is different in meteorlake since that is passed through chip config in devicetree.
https://review.coreboot.org/c/coreboot/+/80504/comment/c344a10d_b4ec3ae4 : PS4, Line 848: s_cfg->CnviBtAudioOffload = 0; Move this check above if (!s_cfg->CnviBtCore && s_cfg->CnviBtAudioOffload). That way this line can be removed?