Attention is currently required from: Arthur Heymans, Haribalaraman Ramasubramanian, Kapil Porwal, Nick Vaccaro, Shelley Chen, Subrata Banik.
3 comments:
Commit Message:
This seems to make sense and allows us
to enable CNVi bluetooth when necessary.
Do you want to have some mechanism at runtime to change them?
Yes. Currently in Brox some SKUs within a same design use discrete WiFi/BT module and some use CNVi/BT as indicated in the TEST message. This is decided by probing the FW_CONFIG mask at run-time.
File src/soc/intel/alderlake/fsp_params.c:
if (!s_cfg->CnviMode && s_cfg->CnviWifiCore) {
printk(BIOS_ERR, "CNVi WiFi is enabled without CNVi being enabled\n");
s_cfg->CnviWifiCore = 0;
}
This check is not required since in alderlake they both are true when the CNVi PCH device is enabled - line 830 and 832. The situation is different in meteorlake since that is passed through chip config in devicetree.
Patch Set #4, Line 848: s_cfg->CnviBtAudioOffload = 0;
Move this check above if (!s_cfg->CnviBtCore && s_cfg->CnviBtAudioOffload). That way this line can be removed?
To view, visit change 80504. To unsubscribe, or for help writing mail filters, visit settings.