Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31026 )
Change subject: AGESA/binaryPI: Add NULL pointers check
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31026/2/src/northbridge/amd/agesa/family16kb...
File src/northbridge/amd/agesa/family16kb/northbridge.c:
https://review.coreboot.org/#/c/31026/2/src/northbridge/amd/agesa/family16kb...
PS2, Line 576: dev = pcidev_on_root(1, 1);
For each file, maybe reverse the check to print an error and get out? […]
It is not an error to have IGD 0:1.0 and associated HDA(?) 0:1.1 not present.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I785350c171a642207c5fab884a953d45a3bfe592
Gerrit-Change-Number: 31026
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Mon, 21 Jan 2019 19:20:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment