Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add definition for ENV_ROMSTAGE_OR_BEFORE to <rules.h> ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34939/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34939/10//COMMIT_MSG@9 PS10, Line 9: ENV_BEFORE_RAMSTAGE is the generic replacement for __PRE_RAM__.
I am fine with either. […]
Done
https://review.coreboot.org/c/coreboot/+/34939/10/src/arch/x86/include/arch/... File src/arch/x86/include/arch/early_variables.h:
https://review.coreboot.org/c/coreboot/+/34939/10/src/arch/x86/include/arch/... PS10, Line 23: /* Just defined locally to avoid rewriting this file. */
How many times do we want to rewrite this just because a longer name might hit 96 line lengths until […]
CB:35016
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h@276 PS10, Line 276: !CONFIG(ARCH_X86)
As this patchset demonstrates, ENV_CACHE_AS_RAM seems to have no use outside x86 <arch/early_variabl […]
Done