[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8196: Add mtcmos init support

[Elyes Haouas (Code Review)]

Attention is currently required from: Guangjie Song, Hung-Te Lin, Jarried Lin.

Elyes Haouas has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84497?usp=email )

Change subject: soc/mediatek/mt8196: Add mtcmos init support
......................................................................

Patch Set 35:

(2 comments)

File src/soc/mediatek/mt8196/mtcmos.c:

https://review.coreboot.org/c/coreboot/+/84497/comment/925359bb_e888ffdf?usp... :
PS35, Line 7: include <assert.h>
            : #include <console/console.h>
            : #include <delay.h>
            : #include <soc/addressmap.h>
            : #include <soc/mtcmos.h>
            : #include <soc/pll.h>
            : #include <soc/spm_mtcmos.h>
            : #include <string.h>
            : #include <timer.h>
I'm not sure if you are using all those headers.

https://review.coreboot.org/c/coreboot/+/84497/comment/74c8c090_f45edfe1?usp... :
PS35, Line 353: int
maybe "enum cb_err" ?