Attention is currently required from: Henry Sun, Ben Kao, Karthik Ramasubramanian.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55935 )
Change subject: mb/google/dedede/var/cret: Disable SDCard controller
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Should we also configure the SD Card GPIOs as PAD_NC for Cret?
Thank you for review.
CB:51629 set GPP_H1, GPP_G0 ~ GPP_G7 to PAD_NC already,
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I889f0545883aa75813dd91dc3e6a4dcfc246687f
Gerrit-Change-Number: 55935
Gerrit-PatchSet: 1
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Ben Kao
ben.kao@intel.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Ben Kao
ben.kao@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 01 Jul 2021 03:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment