Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78141?usp=email )
Change subject: util/docker: Fix setting SDK_VERSION ......................................................................
util/docker: Fix setting SDK_VERSION
The `SDK_VERSION` was incorrectly set to itself instead of keeping the `COREBOOT_IMAGE_TAG` variable, leaving it as an empty string.
Test: Run `make coreboot-sdk` and see `SDK_VERSION` matches the tag.
Fixes: d3a89cdb749a ("util/docker: Replace use of sed with build args") Change-Id: I4c8be7d0f7c1ac82da397e720d13a7075f22ec4d Signed-off-by: Tim Crawford tcrawford@system76.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/78141 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Martin L Roth gaumless@gmail.com --- M util/docker/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Felix Singer: Looks good to me, approved Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/util/docker/Makefile b/util/docker/Makefile index ca274b7..77526bb 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -44,7 +44,7 @@ @echo "Building coreboot SDK $(crossgcc_version) from commit $(DOCKER_COMMIT)" $(DOCKER) build \ --tag coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \ - --build-arg=SDK_VERSION="$(SDK_VERSION)" \ + --build-arg=SDK_VERSION="$(COREBOOT_IMAGE_TAG)" \ --build-arg=DOCKER_COMMIT="$(DOCKER_COMMIT)" \ --build-arg=CROSSGCC_PARAM="$(COREBOOT_CROSSGCC_PARAM)" \ coreboot-sdk