Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30932 )
Change subject: soc/intel/fsp_broadwell_de: Fix TSEG size computation
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30932/1/src/soc/intel/fsp_broadwell_de/smmre...
File src/soc/intel/fsp_broadwell_de/smmrelocate.c:
https://review.coreboot.org/#/c/30932/1/src/soc/intel/fsp_broadwell_de/smmre...
PS1, Line 229: + 1 * MiB;
As the lower address bits are don't care, you decode all addresses in range [0x00000-0xfffff], which […]
Ahh, since in the next line the overall size is computed
(tseg_size = tseg_limit - tseg_base;) and tseg_limit is not used anymore, the size computation corrects a possible off-by-one case.
That makes sense now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a625f7bb53a3e90d3cbc0ce16021892861367d8
Gerrit-Change-Number: 30932
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrea Barberio
insomniac@slackware.it
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Jan 2019 12:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment