Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37649 )
Change subject: mb/google/octopus/variants/bobba: fix LTE power sequence
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37649/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37649/1//COMMIT_MSG@10
PS1, Line 10:
Here the problem is function power_off_lte_module() can't called in smm stage, so add variant. […]
Can get_board_sku() be put into a separate file - eg. board_info.c or mainboard_misc.c. Then that file can be compiled in ramstage and smm stages.
That way we don't have to re-implement it.
Also you can mention the problem details you shared in the response in the commit summary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I287ba1cb092a95b3a9dd1f960a3b84fd85b9b221
Gerrit-Change-Number: 37649
Gerrit-PatchSet: 2
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 12 Dec 2019 18:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment