Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36418 )
Change subject: cpu/x86: Introduce .near_reset_vector ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36418/1/src/cpu/x86/16bit/entry16.i... File src/cpu/x86/16bit/entry16.inc:
https://review.coreboot.org/c/coreboot/+/36418/1/src/cpu/x86/16bit/entry16.i... PS1, Line 44: .type _start16bit, @function
Address was changed by how high I'd put it originally and that's changed now. […]
Ack
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/entry16.i... File src/cpu/x86/16bit/entry16.inc:
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/entry16.i... PS3, Line 34: #endif
I would drop the C_ENV_BOOTBLOCK_SIZE condition here. The assembly we put in . […]
I'll give it a try. Have successfully built a number of boards with smaller sizes, so hopefully it'll fly.
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/entry16.i... PS3, Line 41: .align 4096
I understand some people are a bit upset having the bootblock size increased, only SIPI_VECTOR_IN_RO […]
N/A now
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l... File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l... PS3, Line 29: #endif
I think you could do all of the above unconditionally. […]
Same as in the other comment. Seems to be working ok locally.