Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41392 )
Change subject: libpayload/cbgfx: Remove gap between adjacent boxes ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... PS1, Line 82: while (d > INT32_MAX || d < INT32_MIN) {
new bits added on the left side are usually 0, but if the first operand is a signed negative value, then the added bits will be either 0 or whatever value was previously in the leftmost bit position.
[2] also mentions that the result is implementation-dependent.
[2] https://stackoverflow.com/questions/7622/are-the-shift-operators-arithmetic-...