Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32529 )
Change subject: SKL: add ACPI brightness control ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/32529/4/src/soc/intel/common/block/graphics/... File src/soc/intel/common/block/graphics/graphics.c:
https://review.coreboot.org/#/c/32529/4/src/soc/intel/common/block/graphics/... PS4, Line 23: #include <soc/i915.h> remove after adding gma_ssdt() definition to intelblocks/graphics.h
https://review.coreboot.org/#/c/32529/4/src/soc/intel/skylake/graphics.c File src/soc/intel/skylake/graphics.c:
https://review.coreboot.org/#/c/32529/4/src/soc/intel/skylake/graphics.c@136 PS4, Line 136: void gma_ssdt(struct device *dev) add include <intelblocks/graphics.h> after moving definition there
https://review.coreboot.org/#/c/32529/4/src/soc/intel/skylake/include/soc/i9... File src/soc/intel/skylake/include/soc/i915.h:
https://review.coreboot.org/#/c/32529/4/src/soc/intel/skylake/include/soc/i9... PS4, Line 29: void gma_ssdt(struct device *dev); probably need to move this to intelblocks/graphics.h