build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35241 )
Change subject: mb/google/drallion: dynamic disable memory channel ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35241/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35241/1/src/mainboard/google/dralli... PS1, Line 65: memupd->FspmConfig.DisableDimmChannel0 = gpio_get(GPP_F1)? 0 : 3; spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/35241/1/src/mainboard/google/dralli... PS1, Line 66: memupd->FspmConfig.DisableDimmChannel1 = gpio_get(GPP_F2)? 0 : 3; spaces required around that '?' (ctx:VxW)