Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37258 )
Change subject: Add compatibility mode
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/em100/+/37258/1/image.c
File image.c:
https://review.coreboot.org/c/em100/+/37258/1/image.c@120
PS1, Line 120: ifd_version
maybe return instead of using a global?
Done
https://review.coreboot.org/c/em100/+/37258/1/image.c@125
PS1, Line 125: set_spi_frequency
prefix with ifd_ to make clear that it's ifd specific?
Done
https://review.coreboot.org/c/em100/+/37258/1/image.c@141
PS1, Line 141: set_em100_mode
ditto
Done
--
To view, visit
https://review.coreboot.org/c/em100/+/37258
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ie02264facb028841d18ed84680ffa40f45987510
Gerrit-Change-Number: 37258
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 Nov 2019 01:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment