5 Jan
2021
5 Jan
'21
9:51 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48806 )
Change subject: mb/prodrive/hermes: Define board settings in EEPROM ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48806/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/eeprom.c:
https://review.coreboot.org/c/coreboot/+/48806/1/src/mainboard/prodrive/herm... PS1, Line 42: if (read_write_config(board_cfg, EEPROM_OFFSET_BOARD_SETTINGS, 0, sizeof(*board_cfg))) {
static variables are not globals. […]
Ah wait, let me try something.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48806
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id86632192ae53fd6b0e4df5b26b5a0a81e972818
Gerrit-Change-Number: 48806
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Jan 2021 12:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment