Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86307?usp=email )
Change subject: mb/starlabs/starbook/mtl: Add rcomp configuration ......................................................................
mb/starlabs/starbook/mtl: Add rcomp configuration
Add rcomp configuration values taken from the AMI CRB. This fixes failed memory training for certain memory modules.
Change-Id: If7a29bbd015d45eac178480ba6cae42912e25195 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86307 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/mtl/romstage.c 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c index 14b2664..26a4e5e 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c @@ -13,6 +13,10 @@ .UserBd = BOARD_TYPE_MOBILE, .ddr_config = { .dq_pins_interleaved = false, + }, + .rcomp = { + .resistor = 100, + .targets = {70, 30, 25, 25, 25}, } };