Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38743/1/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/acpi/peg.asl:
https://review.coreboot.org/c/coreboot/+/38743/1/src/northbridge/intel/haswe...
PS1, Line 23: ShiftRight (_SB.PCI0.MCHC.DVEN, 3, Local0)
: Return (And (Local0, 1))
This looks nicer in new ASL syntax:
Local0 = _SB.PCI0.MCHC.DVEN >> 3
Return Local0 & 1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38743
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5f089fb6fd774e6c61f4f9281e2945bd44edf27
Gerrit-Change-Number: 38743
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002789
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002789
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 07 Feb 2020 16:13:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment