Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons, Aamir Bohra. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50913 )
Change subject: intel/common/block/cpu: Add APIs to get CPU info from lapic ID ......................................................................
Patch Set 3:
(6 comments)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/50913/comment/901ab3f0_c2fc0567 PS2, Line 422: level_num
Added an assert for SMT, SDM states sub-leaf index 0 enumerates SMT level.
Ack.
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/50913/comment/f9d13d92_8660d854 PS3, Line 21: res nit: Name this val instead of res? "res" is used in macros below to mean cpuid_result and here it means value from one of the regs.
https://review.coreboot.org/c/coreboot/+/50913/comment/ef750db4_acc9a5ce PS3, Line 25: 0xFF nit: hex digits use lowercase above and uppercase here. Use one for consistency.
https://review.coreboot.org/c/coreboot/+/50913/comment/f5c6b822_e44de98b PS3, Line 403: void static void
https://review.coreboot.org/c/coreboot/+/50913/comment/a645f0fd_04f05757 PS3, Line 428: nit: extra space
File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/50913/comment/b171afd6_6af59279 PS3, Line 164: : /* Get number of bits for core ID and SMT ID */ : void get_cpu_core_thread_bits(uint32_t *core_bits, uint32_t *thread_bits); This doesn't need to be exposed outside of the .c file.