Attention is currently required from: Felix Singer, Tim Wawrzynczak, Michael Niewöhner. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb: add new board clevo/tgl-u/l140mu ......................................................................
Patch Set 8: Code-Review+1
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59548/comment/f1b162a4_68f01d55 PS8, Line 12: - On-board RAM and DIMM slot If you have the model numbers at hand, that’d be great to have documented.
https://review.coreboot.org/c/coreboot/+/59548/comment/d9b682b9_3d32fd1a PS8, Line 25: I couldn't test anything more due to security policy Dot/period at the end.
https://review.coreboot.org/c/coreboot/+/59548/comment/4c3ae4f7_96aa91e9 PS8, Line 26: TianoCore The one from Kconfig, that means MrChromebox’ version?
https://review.coreboot.org/c/coreboot/+/59548/comment/b8a9ef61_528d62ce PS8, Line 27: How did you figure out the GPIOs? inteltool?
https://review.coreboot.org/c/coreboot/+/59548/comment/bc2c9117_9b61a425 PS8, Line 48: - TPM interrupt on Linux [1] Probably that took a large chunk of time to figure out. Hopefully not more than making the actual coreboot port.
https://review.coreboot.org/c/coreboot/+/59548/comment/f8a91d26_1aa8be34 PS8, Line 56: It’d be great, if you also added, if flashrom’s internal programmer works with the vendor firmware, so coreboot can be written to the BIOS region.
Patchset:
PS8: Awesome stuff. Thank you.