Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31900 )
Change subject: device: Rename scan_static_bus() -> enable_static_devices()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31900/2/src/device/root_device.c
File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/31900/2/src/device/root_device.c@46
PS2, Line 46: enable_static_devices
If this is really enable devices, then shouldn't it be called as part of enable_dev() and not scan_bus()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c9dc437b6117112bb28550855a2c38044dfbfa5
Gerrit-Change-Number: 31900
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 19 Sep 2019 15:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment