Attention is currently required from: Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51633 )
Change subject: device/azalia_device.c: Move valid timeout delay to Kconfig
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
It's a timeout for an error case, right? Why not just use the […]
I have an idea: keep the timeout value as-is in this commit, and have CB:51634 remove the odd-looking 25 µs delay and increase the default Kconfig value to 1000 ms (maximum on all implementations).
Would this approach be a good idea? Or should I forego the `AZALIA_VALID_TIMEOUT_US` Kconfig option altogether, and simply adjust the timeout values?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51633
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia025c3fe6813f2b1c0e3ceca686bf5f76b7bca75
Gerrit-Change-Number: 51633
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 22 Mar 2021 11:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
