Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41720 )
Change subject: mb/ocp/deltalake: Update SMBIOS type 0 firmware version by VPD variable ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41720/3/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/41720/3/src/mainboard/ocp/deltalake... PS3, Line 18: if (vpd_gets("version", version, VER_LEN, VPD_RO)) {
suspect code indent for conditional statements (8, 24)
Done
https://review.coreboot.org/c/coreboot/+/41720/3/src/mainboard/ocp/deltalake... PS3, Line 19: printk(BIOS_DEBUG, "Get version from VPD: %s\n",version);
space required after that ',' (ctx:VxV)
Done