[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add Jasper lake GPIO support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39111 )

Change subject: soc/intel/tigerlake: Add Jasper lake GPIO support
......................................................................

Patch Set 17:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39111/15/src/soc/intel/tigerlake/in... 
File src/soc/intel/tigerlake/include/soc/gpio.h:

https://review.coreboot.org/c/coreboot/+/39111/15/src/soc/intel/tigerlake/in... 
PS15, Line 41: /* Common macro definition for gpio_op.asl file */
> Ack […]

This change uses a mask of 0x3 i.e. 2-bit mask. However, common code uses 3-bit mask under the assumption that the NF can go only upto 7.

What does the EDS say for JSL? And is it the same for TGL?

Wouldn't we anyways need a way to handle this in common code since that macro(PAD_CFG0_MODE_MASK) gets used in common gpio block driver as well.