Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80083?usp=email )
Change subject: soc/amd: factor out non-CAR romstage to common code ......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/block/acpimmio/Kconfig:
https://review.coreboot.org/c/coreboot/+/80083/comment/c9c30428_3b94bdbd : PS2, Line 21: config SOC_AMD_COMMON_ROMSTAGE_LEGACY_DMA_FIXUP
Put this in the soc/amd/common/block/cpu Kconfig?
wasn't sure if i should put this into the acpimmio or the cpu block's kconfig, but thinking a bit more about it, the cpu block's kconfig is probably the better choice, since now i can put that option inside the noncar part
File src/soc/amd/common/block/cpu/noncar/romstage.c:
https://review.coreboot.org/c/coreboot/+/80083/comment/4419f27c_351cb5fe : PS2, Line 32: Fixup
Nit: This should just be 'fix' or two words, 'fix up'. […]
that part is from one of the files where i copied the code from, but since i'm reworking the patches anyway, i'll just fix that up ;P