Attention is currently required from: Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48851 )
Change subject: soc/amd: Rename to pm_fill_gnvs()
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/c/coreboot/+/48851/comment/b047c57a_4e1c146f
PS2, Line 408: state = cbmem_find(CBMEM_ID_POWER_STATE);
Idea for a future patch: Unify `set_nvs_sws` between stoney and picasso.
I'm just writing it down here because I will most likely end up forgetting about it. If someone else wants to try, I'll be happy to review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80f92bed737904e6ffc858b45459405fe76f1d04
Gerrit-Change-Number: 48851
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 12 Jan 2021 13:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment