1 Feb
2020
1 Feb
'20
10:59 p.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )
Change subject: coreinfo: Add support for link time optimization ......................................................................
Patch Set 2:
(2 comments)
Did you also test with Clang?
https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:
https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 61: default n I’d default to yes, as less size is more important for firmware purposes.
https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 65: Please mention, if libpayload is then also indirectly built with LTO.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f
Gerrit-Change-Number: 38293
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 01 Feb 2020 22:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment